-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match Wake On LAN Cluster
to spec
#30214
Conversation
PR #30214: Size comparison from 754a938 to b02c59a Increases (15 builds for bl702, bl702l, cc32xx, esp32, linux, psoc6)
Decreases (7 builds for esp32, linux, nrfconnect, psoc6, telink)
Full report (61 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/app/zap-templates/zcl/data-model/chip/wake-on-lan-cluster.xml
Outdated
Show resolved
Hide resolved
PR #30214: Size comparison from eb2f8f6 to 62b1efe Increases (2 builds for cc32xx)
Full report (5 builds for cc32xx, mbed, qpg)
|
PR #30214: Size comparison from eb2f8f6 to ca375db Increases (18 builds for bl702, bl702l, cc32xx, esp32, linux, psoc6)
Decreases (10 builds for esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30214: Size comparison from a61a58f to cf7c29b Increases above 0.2%:
Increases (18 builds for bl702, bl702l, cc32xx, esp32, linux, psoc6)
Decreases (9 builds for esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30214: Size comparison from 3f91ae9 to b885c4d Increases (10 builds for bl702, bl702l, cc32xx, esp32)
Decreases (4 builds for esp32, nrfconnect)
Full report (34 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, k32w, mbed, nrfconnect, qpg)
|
PR #30214: Size comparison from 9332885 to 88cb7e8 Increases above 0.2%:
Increases (18 builds for bl702, bl702l, cc32xx, esp32, linux, psoc6)
Decreases (9 builds for esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30214: Size comparison from f72c875 to 24d23e8 Increases above 0.2%:
Increases (18 builds for bl702, bl702l, cc32xx, esp32, linux, psoc6)
Decreases (9 builds for esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
24d23e8
to
ee85ed2
Compare
PR #30214: Size comparison from 155917e to ee85ed2 Increases above 0.2%:
Increases (18 builds for bl702, bl702l, cc32xx, esp32, linux, psoc6)
Decreases (9 builds for esp32, linux, nrfconnect, psoc6, telink)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
This makes the cluster closer to spec.
Changes:
I will have to make a spec change for MacAddressType (as sdk uses strings, spec says binary mac ...)
Spec change: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7911